Amended Button still not in Nightly Build

classic Classic list List threaded Threaded
12 messages Options
Reply | Threaded
Open this post in threaded view
|

Amended Button still not in Nightly Build

doug777
I can see the Button component has had the mouse events added for the js
compiler at
https://github.com/apache/royale-asjs/blob/develop/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/Button.as

That's great and many thanks for that!

But it's still not in the Nightly builds.

This file in the downloaded sdk
frameworks\projects\Basic\src\main\flex\org\apache\flex\html\Button.as is
still the unamended version with only the click event available for js.

Any chance the updated version could be added to the nightly builds sometime
soon?

Doug



--
Sent from: http://apache-royale-users.20374.n8.nabble.com/
Reply | Threaded
Open this post in threaded view
|

Re: Amended Button still not in Nightly Build

Piotr Zarzycki
Hi Doug,

Where did you download your nightly build ? It looks like it is not the right place. The Royale nightly build is here [1] (JS, SWF) version, [2] (JSOnly)


Thanks, Piotr

2018-02-08 10:24 GMT+01:00 doug777 <[hidden email]>:
I can see the Button component has had the mouse events added for the js
compiler at
https://github.com/apache/royale-asjs/blob/develop/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/Button.as

That's great and many thanks for that!

But it's still not in the Nightly builds.

This file in the downloaded sdk
frameworks\projects\Basic\src\main\flex\org\apache\flex\html\Button.as is
still the unamended version with only the click event available for js.

Any chance the updated version could be added to the nightly builds sometime
soon?

Doug



--
Sent from: http://apache-royale-users.20374.n8.nabble.com/



--

Piotr Zarzycki 

Patreon: https://www.patreon.com/piotrzarzycki

Reply | Threaded
Open this post in threaded view
|

Re: Amended Button still not in Nightly Build

doug777
I used the Apache Flex SDK Installer. Is there an update for this or is this
not working any more for Dev builds?

Doug



--
Sent from: http://apache-royale-users.20374.n8.nabble.com/
Reply | Threaded
Open this post in threaded view
|

Re: Amended Button still not in Nightly Build

Alex Harui-2
In reply to this post by Piotr Zarzycki
Also make sure you clean or delete your bin/js-debug and bin/js-release folders.  The compiler does not overwrite your bin/js-debug files that come from SWCs because it assumes they haven't changed and speeds up compilation.  Only the output .js files for the source that is being compiled overwrites existing .js files.  So, you can upgrade to a later build and find that your JS app doesn't pick up fixes because it is still using older versions.

HTH,
-Alex

From: Piotr Zarzycki <[hidden email]>
Reply-To: "[hidden email]" <[hidden email]>
Date: Thursday, February 8, 2018 at 1:28 AM
To: "[hidden email]" <[hidden email]>
Subject: Re: Amended Button still not in Nightly Build

Hi Doug,

Where did you download your nightly build ? It looks like it is not the right place. The Royale nightly build is here [1] (JS, SWF) version, [2] (JSOnly)


Thanks, Piotr

2018-02-08 10:24 GMT+01:00 doug777 <[hidden email]>:
I can see the Button component has had the mouse events added for the js
compiler at
https://github.com/apache/royale-asjs/blob/develop/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/Button.as

That's great and many thanks for that!

But it's still not in the Nightly builds.

This file in the downloaded sdk
frameworks\projects\Basic\src\main\flex\org\apache\flex\html\Button.as is
still the unamended version with only the click event available for js.

Any chance the updated version could be added to the nightly builds sometime
soon?

Doug



--
Sent from: http://apache-royale-users.20374.n8.nabble.com/



--

Piotr Zarzycki 

Patreon: https://www.patreon.com/piotrzarzycki

Reply | Threaded
Open this post in threaded view
|

Re: Amended Button still not in Nightly Build

Piotr Zarzycki
Doug,

Exactly. Installer won't work anymore. You will have to use manual download or Node npm. Take a look into our website [1]


Thanks, Piotr


2018-02-08 10:33 GMT+01:00 Alex Harui <[hidden email]>:
Also make sure you clean or delete your bin/js-debug and bin/js-release folders.  The compiler does not overwrite your bin/js-debug files that come from SWCs because it assumes they haven't changed and speeds up compilation.  Only the output .js files for the source that is being compiled overwrites existing .js files.  So, you can upgrade to a later build and find that your JS app doesn't pick up fixes because it is still using older versions.

HTH,
-Alex

From: Piotr Zarzycki <[hidden email]>
Reply-To: "[hidden email]" <[hidden email]>
Date: Thursday, February 8, 2018 at 1:28 AM
To: "[hidden email]" <[hidden email]>
Subject: Re: Amended Button still not in Nightly Build

Hi Doug,

Where did you download your nightly build ? It looks like it is not the right place. The Royale nightly build is here [1] (JS, SWF) version, [2] (JSOnly)


Thanks, Piotr

2018-02-08 10:24 GMT+01:00 doug777 <[hidden email]>:
I can see the Button component has had the mouse events added for the js
compiler at
https://github.com/apache/royale-asjs/blob/develop/frameworks/projects/Basic/src/main/royale/org/apache/royale/html/Button.as

That's great and many thanks for that!

But it's still not in the Nightly builds.

This file in the downloaded sdk
frameworks\projects\Basic\src\main\flex\org\apache\flex\html\Button.as is
still the unamended version with only the click event available for js.

Any chance the updated version could be added to the nightly builds sometime
soon?

Doug



--
Sent from: http://apache-royale-users.20374.n8.nabble.com/



--

Piotr Zarzycki 

Patreon: https://www.patreon.com/piotrzarzycki




--

Piotr Zarzycki 

Patreon: https://www.patreon.com/piotrzarzycki

Reply | Threaded
Open this post in threaded view
|

Re: Amended Button still not in Nightly Build

doug777
OK got it. Thanks to you both.

Doug



--
Sent from: http://apache-royale-users.20374.n8.nabble.com/
Reply | Threaded
Open this post in threaded view
|

Re: Amended Button still not in Nightly Build

Piotr Zarzycki
Yeah. I'm quite often clean the build before starting it with Royale projects. I think we should have in Moonshine options which combine those two steps. :)
1) Clean
2) Build

Thanks,
Piotr

2018-02-08 10:39 GMT+01:00 doug777 <[hidden email]>:
OK got it. Thanks to you both.



--

Piotr Zarzycki 

Patreon: https://www.patreon.com/piotrzarzycki

Reply | Threaded
Open this post in threaded view
|

Re: Amended Button still not in Nightly Build

Alex Harui-2
A clean option in an IDE is a good idea, but it doesn't have to be manually operated.  Moonshine and other IDEs could get smarter and detect that a SWC's date has changed and do a clean.  The compiler itself doesn't memorize stuff like SWC dates, but an IDE can.

My 2 cents,
-Alex

From: Piotr Zarzycki <[hidden email]>
Reply-To: "[hidden email]" <[hidden email]>
Date: Thursday, February 8, 2018 at 1:44 AM
To: "[hidden email]" <[hidden email]>
Subject: Re: Amended Button still not in Nightly Build

Yeah. I'm quite often clean the build before starting it with Royale projects. I think we should have in Moonshine options which combine those two steps. :)
1) Clean
2) Build

Thanks,
Piotr

2018-02-08 10:39 GMT+01:00 doug777 <[hidden email]>:
OK got it. Thanks to you both.



--

Piotr Zarzycki 

Patreon: https://www.patreon.com/piotrzarzycki

Reply | Threaded
Open this post in threaded view
|

Re: Amended Button still not in Nightly Build

Piotr Zarzycki
Problem is not about swc, problem is about that some files in JS output has been left. For example if you in one build had file X, for another build that files has been removed it doesn't mean that it disappear from the js-debug folder.

Piotr 

2018-02-08 18:47 GMT+01:00 Alex Harui <[hidden email]>:
A clean option in an IDE is a good idea, but it doesn't have to be manually operated.  Moonshine and other IDEs could get smarter and detect that a SWC's date has changed and do a clean.  The compiler itself doesn't memorize stuff like SWC dates, but an IDE can.

My 2 cents,
-Alex

From: Piotr Zarzycki <[hidden email]>
Reply-To: "[hidden email]" <[hidden email]>
Date: Thursday, February 8, 2018 at 1:44 AM
To: "[hidden email]" <[hidden email]>
Subject: Re: Amended Button still not in Nightly Build

Yeah. I'm quite often clean the build before starting it with Royale projects. I think we should have in Moonshine options which combine those two steps. :)
1) Clean
2) Build

Thanks,
Piotr

2018-02-08 10:39 GMT+01:00 doug777 <[hidden email]>:
OK got it. Thanks to you both.



--

Piotr Zarzycki 

Patreon: https://www.patreon.com/piotrzarzycki




--

Piotr Zarzycki 

Patreon: https://www.patreon.com/piotrzarzycki

Reply | Threaded
Open this post in threaded view
|

Re: Amended Button still not in Nightly Build

Alex Harui-2
You are correct that if we make a file go away from an upgrade to a SWC that the compiler does not know to delete the now obsolete JS file.  But does that actually cause something to break?

IMO, the only time I've been burned is when we update a file in a SWC.  And that can be detected by the IDEs.

-Alex

From: Piotr Zarzycki <[hidden email]>
Reply-To: "[hidden email]" <[hidden email]>
Date: Thursday, February 8, 2018 at 9:50 AM
To: "[hidden email]" <[hidden email]>
Subject: Re: Amended Button still not in Nightly Build

Problem is not about swc, problem is about that some files in JS output has been left. For example if you in one build had file X, for another build that files has been removed it doesn't mean that it disappear from the js-debug folder.

Piotr 

2018-02-08 18:47 GMT+01:00 Alex Harui <[hidden email]>:
A clean option in an IDE is a good idea, but it doesn't have to be manually operated.  Moonshine and other IDEs could get smarter and detect that a SWC's date has changed and do a clean.  The compiler itself doesn't memorize stuff like SWC dates, but an IDE can.

My 2 cents,
-Alex

From: Piotr Zarzycki <[hidden email]>
Reply-To: "[hidden email]" <[hidden email]>
Date: Thursday, February 8, 2018 at 1:44 AM
To: "[hidden email]" <[hidden email]>
Subject: Re: Amended Button still not in Nightly Build

Yeah. I'm quite often clean the build before starting it with Royale projects. I think we should have in Moonshine options which combine those two steps. :)
1) Clean
2) Build

Thanks,
Piotr

2018-02-08 10:39 GMT+01:00 doug777 <[hidden email]>:
OK got it. Thanks to you both.



--

Piotr Zarzycki 

Patreon: https://www.patreon.com/piotrzarzycki




--

Piotr Zarzycki 

Patreon: https://www.patreon.com/piotrzarzycki

Reply | Threaded
Open this post in threaded view
|

Re: Amended Button still not in Nightly Build

Piotr Zarzycki
Alex,

I'm not sure why you are mentioning about swc. I'm talking about real world application which is compiling to the bunch of JavaScript files. Maybe I don't understand your way of thinking.


2018-02-08 19:19 GMT+01:00 Alex Harui <[hidden email]>:
You are correct that if we make a file go away from an upgrade to a SWC that the compiler does not know to delete the now obsolete JS file.  But does that actually cause something to break?

IMO, the only time I've been burned is when we update a file in a SWC.  And that can be detected by the IDEs.

-Alex

From: Piotr Zarzycki <[hidden email]>
Reply-To: "[hidden email]" <[hidden email]>
Date: Thursday, February 8, 2018 at 9:50 AM

To: "[hidden email]" <[hidden email]>
Subject: Re: Amended Button still not in Nightly Build

Problem is not about swc, problem is about that some files in JS output has been left. For example if you in one build had file X, for another build that files has been removed it doesn't mean that it disappear from the js-debug folder.

Piotr 

2018-02-08 18:47 GMT+01:00 Alex Harui <[hidden email]>:
A clean option in an IDE is a good idea, but it doesn't have to be manually operated.  Moonshine and other IDEs could get smarter and detect that a SWC's date has changed and do a clean.  The compiler itself doesn't memorize stuff like SWC dates, but an IDE can.

My 2 cents,
-Alex

From: Piotr Zarzycki <[hidden email]>
Reply-To: "[hidden email]" <[hidden email]>
Date: Thursday, February 8, 2018 at 1:44 AM
To: "[hidden email]" <[hidden email]>
Subject: Re: Amended Button still not in Nightly Build

Yeah. I'm quite often clean the build before starting it with Royale projects. I think we should have in Moonshine options which combine those two steps. :)
1) Clean
2) Build

Thanks,
Piotr

2018-02-08 10:39 GMT+01:00 doug777 <[hidden email]>:
OK got it. Thanks to you both.



--

Piotr Zarzycki 

Patreon: https://www.patreon.com/piotrzarzycki




--

Piotr Zarzycki 

Patreon: https://www.patreon.com/piotrzarzycki




--

Piotr Zarzycki 

Patreon: https://www.patreon.com/piotrzarzycki

Reply | Threaded
Open this post in threaded view
|

Re: Amended Button still not in Nightly Build

Alex Harui-2
In bin/js-debug is a pile of JS files.  Some of them come from SWCs, some come from the compiling of your application sources.  Every time you run the compiler, the JS files corresponding to your application source MXML and AS files are overwritten.  But the JS files corresponding to classes from a SWC are not overwritten.  So, if I change to a newer SWC with a fix for Button, the Button.js will not be updated and I wonder why my fix didn't work.  That's the only time I get burned by the logic that handles JS files in bin/js-debug.

You are correct that if you delete a class from a SWC or from your application source that the old JS file will remain in bin/js-debug, but I'm asking if that actually causes a problem.  I didn't think it does.  I don't think the minifier will see that obsolete file.

That my understanding of the problem.
-Alex

From: Piotr Zarzycki <[hidden email]>
Reply-To: "[hidden email]" <[hidden email]>
Date: Thursday, February 8, 2018 at 10:34 AM
To: "[hidden email]" <[hidden email]>
Subject: Re: Amended Button still not in Nightly Build

Alex,

I'm not sure why you are mentioning about swc. I'm talking about real world application which is compiling to the bunch of JavaScript files. Maybe I don't understand your way of thinking.


2018-02-08 19:19 GMT+01:00 Alex Harui <[hidden email]>:
You are correct that if we make a file go away from an upgrade to a SWC that the compiler does not know to delete the now obsolete JS file.  But does that actually cause something to break?

IMO, the only time I've been burned is when we update a file in a SWC.  And that can be detected by the IDEs.

-Alex

From: Piotr Zarzycki <[hidden email]>
Reply-To: "[hidden email]" <[hidden email]>
Date: Thursday, February 8, 2018 at 9:50 AM

To: "[hidden email]" <[hidden email]>
Subject: Re: Amended Button still not in Nightly Build

Problem is not about swc, problem is about that some files in JS output has been left. For example if you in one build had file X, for another build that files has been removed it doesn't mean that it disappear from the js-debug folder.

Piotr 

2018-02-08 18:47 GMT+01:00 Alex Harui <[hidden email]>:
A clean option in an IDE is a good idea, but it doesn't have to be manually operated.  Moonshine and other IDEs could get smarter and detect that a SWC's date has changed and do a clean.  The compiler itself doesn't memorize stuff like SWC dates, but an IDE can.

My 2 cents,
-Alex

From: Piotr Zarzycki <[hidden email]>
Reply-To: "[hidden email]" <[hidden email]>
Date: Thursday, February 8, 2018 at 1:44 AM
To: "[hidden email]" <[hidden email]>
Subject: Re: Amended Button still not in Nightly Build

Yeah. I'm quite often clean the build before starting it with Royale projects. I think we should have in Moonshine options which combine those two steps. :)
1) Clean
2) Build

Thanks,
Piotr

2018-02-08 10:39 GMT+01:00 doug777 <[hidden email]>:
OK got it. Thanks to you both.



--

Piotr Zarzycki 

Patreon: https://www.patreon.com/piotrzarzycki




--

Piotr Zarzycki 

Patreon: https://www.patreon.com/piotrzarzycki




--

Piotr Zarzycki 

Patreon: https://www.patreon.com/piotrzarzycki