Royale wiki pull requests (missing building utils on compiler page)

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Royale wiki pull requests (missing building utils on compiler page)

Justin Mclean
Hi,

It looks like the Royale GitHub wiki is not set up to accept pull requests. In most projects wiki access is given to people who ask but as it’s in GitHub I assume you need to be a committer in order to edit it. Anyone confirm this / expand on what the policy of the project on this is?

Also can someone be kind enough to apply this patch:

diff --git a/Build-Apache-Royale-with-Maven.md b/Build-Apache-Royale-with-Maven.md
index f404c54..abf70b3 100644
--- a/Build-Apache-Royale-with-Maven.md
+++ b/Build-Apache-Royale-with-Maven.md
@@ -46,7 +46,12 @@ It also has a feature of **assembling a fully functional Royale distribution** i
     git checkout develop
     ```

-    3. Build the compiler:
+    3. Build the compiler utilities (if needed):
+    ```
+    mvn -s settings-template.xml clean install -P utils
+    ```
+
+    4. Build the compiler:
     ```
     mvn -s settings-template.xml clean install
     ```

Thanks,
Justin
Reply | Threaded
Open this post in threaded view
|

Re: Royale wiki pull requests (missing building utils on compiler page)

Carlos Rovira-2
Hi Justin,

just made the change, you proposed. Please let me know if is ok.

About how to deal with access in GitHub Wiki, I suppose rules of Apache will apply as well in GitHub Apache projects, but hope Dave could assists us in how this should be done since I'm as well wanting to know.

Thanks!

Carlos

2017-11-20 0:05 GMT+01:00 Justin Mclean <[hidden email]>:
Hi,

It looks like the Royale GitHub wiki is not set up to accept pull requests. In most projects wiki access is given to people who ask but as it’s in GitHub I assume you need to be a committer in order to edit it. Anyone confirm this / expand on what the policy of the project on this is?

Also can someone be kind enough to apply this patch:

diff --git a/Build-Apache-Royale-with-Maven.md b/Build-Apache-Royale-with-Maven.md
index f404c54..abf70b3 100644
--- a/Build-Apache-Royale-with-Maven.md
+++ b/Build-Apache-Royale-with-Maven.md
@@ -46,7 +46,12 @@ It also has a feature of **assembling a fully functional Royale distribution** i
     git checkout develop
     ```

-    3. Build the compiler:
+    3. Build the compiler utilities (if needed):
+    ```
+    mvn -s settings-template.xml clean install -P utils
+    ```
+
+    4. Build the compiler:
     ```
     mvn -s settings-template.xml clean install
     ```

Thanks,
Justin



--